Page MenuHomePhabricator

UploadWizard fails badly with jshint
Closed, ResolvedPublic

Details

Reference
bz47161

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:32 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz47161.

https://github.com/wikimedia/mediawiki-extensions-UploadWizard/pull/1

(Yuvi is going to use this to test his new GH->Gerrit system)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Related URL: https://gerrit.wikimedia.org/r/59064 (Gerrit Change I02772c5c7e570a549b859840ef13f708817661e6)

Don't merge yet, this shall be nice testing grounds for https://github.com/yuvipanda/SuchABot :)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59108 (Gerrit Change I8bde674a36743592f85e42c0b2e205965c4e9f1b)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

Related URL: https://gerrit.wikimedia.org/r/59111 (Gerrit Change I86436fd6128343eff7fe57ff47de409e87a9b946)

It looks like there's still significant amounts of work to do on this - should I leave you assigned, Krenair, or do you want to pass this on to the crowd?

Tooo late. I started a big ol' patch to fix things. I may split it up later if asked nicely.

Sorry, I kept meaning to reply to this but never got around to it. Please 'pass this on to the crowd' :)

Change 80523 had a related patch set uploaded by MarkTraceur:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523

Change 80945 had a related patch set uploaded by MarkTraceur:
More jshint fixes

https://gerrit.wikimedia.org/r/80945

Change 80947 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80947

Change 80523 merged by jenkins-bot:
Loads of work on jshint fixes

https://gerrit.wikimedia.org/r/80523

Once the patches in gerrit are merged, we can mark this bug as fixed and make the jshint job voting in Jenkins. Exciting!

Change 80954 had a related patch set uploaded by MarkTraceur:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954

Change 86776 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776

Change 86777 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777

Change 86778 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778

Change 86779 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779

Change 80945 abandoned by MarkTraceur:
More jshint fixes

Reason:
Split into:

  • If3023606e187afd3ac49739de7545f4fd3ba60f4
  • I66a32316613a0779a7ca3a5b77698cacca1ba11f
  • Iafb382ca73652b254e097dce7521eee6a783a504
  • If7e2ab0fc347841ead3073bc63ba85b4a96795ab

https://gerrit.wikimedia.org/r/80945

Change 86789 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789

Change 86787 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787

Change 80947 abandoned by MarkTraceur:
Further jshint fixes

Reason:
Split into:

  • I3552fcb0ccd4902c3cd02f2c6eb133b752e3d1ff
  • I1c54a2c2f82dcddf8bdfa63ff80b320744aa6b2f

https://gerrit.wikimedia.org/r/80947

Change 86791 had a related patch set uploaded by MarkTraceur:
Ignore unused jasmine tests for jshint

https://gerrit.wikimedia.org/r/86791

Change 86792 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

https://gerrit.wikimedia.org/r/86792

Change 86793 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

https://gerrit.wikimedia.org/r/86793

Change 86794 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

https://gerrit.wikimedia.org/r/86794

Change 86797 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

https://gerrit.wikimedia.org/r/86797

Change 86798 had a related patch set uploaded by MarkTraceur:
jshint fixes for mw.fileApi.js

https://gerrit.wikimedia.org/r/86798

Change 80954 merged by jenkins-bot:
Further jshint fixes

https://gerrit.wikimedia.org/r/80954

Change 86793 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUploadInterface.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86793

Change 86794 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardUtil.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86794

Change 86797 abandoned by MarkTraceur:
jshint fixes for mw.UtilitiesTime.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86797

Change 86798 abandoned by MarkTraceur:
jshint fixes for mw.fileApi.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86798

Change 86792 abandoned by MarkTraceur:
jshint fixes for mw.UploadWizardPage.js

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86792

Change 86791 abandoned by MarkTraceur:
Ignore unused jasmine tests for jshint

Reason:
I0710fd5fb9ce8ad21b7d3a45834fa8955944e433 merged

https://gerrit.wikimedia.org/r/86791

Sorry about all of the notifications - might have been smart to have split this into multiple bugs...ah well, too late to turn back now!

Change 86776 merged by jenkins-bot:
jshint fixes for mw.ConfirmCloseWindow.js

https://gerrit.wikimedia.org/r/86776

Change 86778 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDescription.js

https://gerrit.wikimedia.org/r/86778

  • Bug 61642 has been marked as a duplicate of this bug. ***

Change 86787 merged by jenkins-bot:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/86787

Change 86789 merged by jenkins-bot:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/86789

Change 86779 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDetails.js

https://gerrit.wikimedia.org/r/86779

Change 131685 had a related patch set uploaded by Gilles:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685

Change 131685 merged by jenkins-bot:
Fix missed jshint issues

https://gerrit.wikimedia.org/r/131685

Change 131686 had a related patch set uploaded by Gilles:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686

Change 131686 merged by jenkins-bot:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/131686

Poke (for Yuvi)

Sigh yuvi, poking again

Stop failing yuvi

Change 86777 merged by jenkins-bot:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/86777

So apparently UploadWizard pass the Jenkins job jslint which runs JSHint. Should we consider this bug fixed and make the job voting? :-)

Change 134791 had a related patch set uploaded by Gilles:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791

Change 134791 merged by jenkins-bot:
Make jslint voting for UploadWizard

https://gerrit.wikimedia.org/r/134791

There is nothing left to do now :-) Congratulations!

Amazing job everyone! Woo-hoo!

Change 141190 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190

Change 141195 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195

Change 141198 had a related patch set uploaded by Inchikutty:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198

Change 141209 had a related patch set uploaded by Inchikutty:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209

Change 141209 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardDeed.js

https://gerrit.wikimedia.org/r/141209

Change 141198 abandoned by Alex Monk:
Fix miscellaneous jshint issues

https://gerrit.wikimedia.org/r/141198

Change 141195 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardUpload.js

https://gerrit.wikimedia.org/r/141195

Change 141190 abandoned by Alex Monk:
jshint fixes for mw.UploadWizardLicenseInput.js

https://gerrit.wikimedia.org/r/141190

(Someone reuploaded every change since what appeared to be the 26th of Febuary. I have cleaned them up.)

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:21 AM