Page MenuHomePhabricator

wikibits: FF2Fixes.css should not be loaded in Firefox 20
Closed, ResolvedPublic

Description

I'm running FireFox 20 and I noticed that the feedlink icon was no longer showing up in my toolbox. I saw that it's hidden in FF2Fixes.css. In /skins/common/wikibits.js:

window.ff2_bugs = /firefox\/2/.test( clientPC );

It looks to me like FireFox 20 is being read as FireFox 2, and thus the feedlink icon is being hidden. I'm sure this will be an issue for all of FireFox 20-something version numbers.


Version: 1.20.x
Severity: normal

Details

Reference
bz47202

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz47202.
hoo added a comment.Apr 13 2013, 5:36 PM

Fixed in https://gerrit.wikimedia.org/r/59053 (needs review).

Per default this will only affect Monobook slightly as only that has a F2Fixes.css which is invoked in case wikibits detects the browser as Firefox 2.

But it might also have an impact on extensions and other custom scripts relying on these globals.

hoo added a comment.Apr 13 2013, 5:47 PM

I forgot to mention, that the accesskeys in Firefox 20+ were also broken.

Related URL: https://gerrit.wikimedia.org/r/60254 (Gerrit Change I2fdd0da8c17553a3465ef27c46a4632e135c4405)

(In reply to comment #2)

I forgot to mention, that the accesskeys in Firefox 20+ were also broken.

Can you file a separate bug for that? I doubt whether they are actually broken or whether you should think they are because the code suggests that. Afaik this legacy module is no longer used.

Marking for backport, this needs to go in 1.21 since weremoved the remnants of FF2 support a few days before the 1.21 branch point.

Related URL: https://gerrit.wikimedia.org/r/62213 (Gerrit Change I2fdd0da8c17553a3465ef27c46a4632e135c4405)

ori added a comment.May 4 2013, 3:31 AM

Merged & backported.

Tagging for backport to stable (1.20) since this is affecting that is as well (due to the broken is_ff2 regex).

Since REL1_20 doesn't blacklist firefox 2 yet we should either hotfix the regexp in REL1_20 locally or simply apply the same change to REL1_20 (removing the css hacks for FF2).

Since we've already dropped FF2 in 1.21+ and the css wasn't very maintained, I'd recommend we just remove them.

Related URL: https://gerrit.wikimedia.org/r/62605 (Gerrit Change I2fdd0da8c17553a3465ef27c46a4632e135c4405)

Landed in stable (REL1_20).