default submit in Special:CentralNotice is wrong
Open, LowPublic
Actions

Assigned To

None

Authored By

	awight
	Apr 14 2013, 6:55 PM

Description

Pressing <return> in any of the campaign edit fields will default to the "filter banners" submit, rather than the edit form submit.

Banner filtering should be done using ajax, without a page refresh, or the "add banner" action should open a modal dialog. Or, if we want to do it without javascript, there should be a second form and the main form's submit buttons moved closer to that section of the form.

This issue might be deprecated by work in https://gerrit.wikimedia.org/r/57090

Version: master
Severity: minor

Details

Reference: bz47223

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:37 AM

• bzimport added a project: MediaWiki-extensions-CentralNotice.

• bzimport set Reference to bz47223.

• bzimport added a subscriber: Unknown Object (MLST).

awight created this task.Apr 14 2013, 6:55 PM

(In reply to comment #0 by Adam Wight)

This issue might be deprecated by work in
https://gerrit.wikimedia.org/r/57090

That patch got merged a few weeks ago, so is this deprecated?

mwalker wrote:

No this is still active. I still haven't rewritten the campaign edit interface which is where this bug sits.

• atgo moved this task from Backlog to Later on the MediaWiki-extensions-CentralNotice board.Feb 27 2015, 1:23 AM

awight added a project: Fundraising-Backlog.Sep 15 2015, 7:01 PM

awight set Security to None.

awight added a subscriber: Pcoombe.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2015, 7:01 PM

@Pcoombe: Do you run into this? I'm crazy annoyed trying to use the campaign editor on my dev box.

kaldari unsubscribed.Sep 15 2015, 8:26 PM

@awight I don't tend to hit Return to submit. However it would definitely be nice to improve the banner filtering to be ajax and/or use a separate form.

awight added a project: good first task.Oct 9 2015, 2:36 PM

• DStrine moved this task from Triage to Old Unscheduled (prior to 2019) on the Fundraising-Backlog board.Dec 3 2015, 5:53 PM

• mmodell removed a subscriber: awight.Jun 22 2017, 9:48 PM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 22 2017, 9:48 PM

A good first task is a self-contained, non-controversial task with a clear approach (no "maybe either...or" like here).
It should be well-described with pointers to help a completely new contributor. Hence removing the good first task tag.

default submit in Special:CentralNotice is wrongOpen, LowPublicActions

Description

Details

Event Timeline

default submit in Special:CentralNotice is wrong
Open, LowPublic
Actions