Page MenuHomePhabricator

Plain text email notifications footer should use proper syntax --
Closed, ResolvedPublic

Description

Split out of bug 46315: plan text users deserve fair treatment too. :)

Gerrit, bugzilla, MediaWiki etc. etc. all use -- for footers, which Thunderbird correctly identifies as footers and grays out: please use it instead of the ugly



Version: master
Severity: enhancement

Details

Reference
bz47303

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:42 AM
bzimport added a project: Notifications.
bzimport set Reference to bz47303.

Note: Would be "-- " not "--", though doesn't matter much as it's not supposed to be replied too.

Related URL: https://gerrit.wikimedia.org/r/60186 (Gerrit Change I5baed5e936dfaa9ef1fe11c900ee1ce94ccb748a)

lwelling wrote:

I reviewed the code change.

It was a deliberate style choice to present it as a line, so Vibha and Fabrice should have the opportunity to OK it, but the code diff is fine.

bsitu wrote:

Fabrice and Vibha,

Do you have suggestion about replacing ___________ with --? Note we also use _________ to separate notification categories in email digest. We can replace both of them or only the footer.

Change 60186 merged by jenkins-bot:
Improve footer separator

https://gerrit.wikimedia.org/r/60186