Page MenuHomePhabricator

badlogin CAPTCHA doesn't work in new login form
Closed, ResolvedPublic

Description

The new vertical login form moves the header contents (if any) out of the form. This means that the captcha that appears (by default after three bad login attempts) doesn't work!

To reproduce, visit http://www.mediawiki.org/w/index.php?title=Special:UserLogin&useNew=1 and enter a bad password.


Version: 1.22.0
Severity: normal
URL: http://www.mediawiki.org/w/index.php?title=Special:UserLogin&useNew=1

Details

Reference
bz47371

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz47371.

Munaf and I figured out how to put it back in the form yet avoid Agora styling arbitrary CAPTCHA fields. Patches for both login and create account coming.

Related URL: https://gerrit.wikimedia.org/r/59993 (Gerrit Change I1523fe6551585ba731b0ca4207e22d614d0a46d8)

Related URL: https://gerrit.wikimedia.org/r/60792 (Gerrit Change I1523fe6551585ba731b0ca4207e22d614d0a46d8)

The captcha just got removed right ?

(In reply to comment #2)

Related URL: https://gerrit.wikimedia.org/r/59993 (Gerrit Change
I1523fe6551585ba731b0ca4207e22d614d0a46d8)

Merged.

(In reply to comment #3)

Related URL: https://gerrit.wikimedia.org/r/60792 (Gerrit Change
I1523fe6551585ba731b0ca4207e22d614d0a46d8)

Merged.

What's left to do here?

(In reply to comment #4)

The captcha just got removed right ?

No, it's still there, try to login several times with the wrong password.

Yes, this is fixed reasonably well for most CAPTCHA options. Thanks MZMcBride for following up.