[Regression] VisualEditor: Edit tab should have tooltip and accesskey
Closed, ResolvedPublic

Description

Ordinarily there's an accesskey (e.g. alt+shift+E in Firefox) on the "Edit" tab in Vector. The accesskey is made known to the user through a tooltip. VisualEditor eliminates this accesskey and tooltip, and adds a new "Edit source" tab without an accesskey or tooltip.

Ideally both the "Edit" and "Edit source" tab should have accesskeys and tooltips to allow quick switching between the modes for power users.


Version: unspecified
Severity: normal

bzimport set Reference to bz47396.
Eloquence created this task.Via LegacyApr 19 2013, 7:10 AM
Krinkle added a comment.Via ConduitApr 19 2013, 9:02 AM

When mw.ViewPageTarget has its tabLayout in "replace" mode (where it replaces the regular Edit tab with a VE-version and adds an Edit source tab) the code explicitly copies over the label, tooltip and accesskey.

It appears this isn't working anymore. I worked a week ago. The code hasn't changed so it looks like something else has broken it.

Moving bug to Integration (perhaps the component should be renamed to "MediaWiki integration")

gerritbot added a comment.Via ConduitApr 22 2013, 8:02 AM

Related URL: https://gerrit.wikimedia.org/r/60241 (Gerrit Change If598552fac639da645a8b1273c5fc6028695fcc1)

Krinkle added a comment.Via ConduitApr 22 2013, 8:07 AM

Change-Id: If598552fac639da645a8b1273c5fc6028695fcc1

@@ -777,10 +778,10 @@ ve.init.mw.ViewPageTarget.prototype.setupSkinTabs

			this.veEditUri,
  • $caEdit.text(), + $caEditA.text(), $caEdit.attr( 'id' ),
  • $caEdit.attr( 'title' ),
  • $caEdit.attr( 'accesskey' ), + $caEditA.attr( 'title' ), + $caEditA.attr( 'accesskey' ), caVeEditSource ); }
Jdforrester-WMF added a comment.Via ConduitApr 23 2013, 7:34 PM

Code is now merged and will go out on Thursday.

Add Comment