Page MenuHomePhabricator

Parsoid: Extra new line in wikitext causes <br> that makes parent <p> typeof="mw:Placeholder"
Closed, ResolvedPublic

Description

Author: dayuloli

Description:
Unable to edit

Unable to edit the last paragraph of this article. Unable to reproduce this with other articles. Consistent across Google Chrome and Mozilla Aurora.


Version: unspecified
Severity: trivial
OS: Windows 7
Platform: PC
URL: http://en.wikipedia.org/wiki/Generalization_(learning)

Attached:

Details

Reference
bz47403

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:19 AM
bzimport set Reference to bz47403.

This appears to result from Parsoid giving:

<p typeof="mw:Placeholder" data-parsoid="…"><br data-parsoid="…">
Generalization has been shown to be refined and/or stabilized after sleep.<span id="cite_ref-2-0" class="reference" about="#mwt5" typeof="mw:Object/Ext/Ref" data-parsoid="…"><a href="#cite_note-2" data-parsoid="{}">[2]</a></span></p>

The typeof="mw:Placeholder" presumably comes from the extra new line between the paragraphs creating a <br>? Is this intended behaviour that VE should adjust for?

We are protecting the p/br paragraphs as the VE did not support them well so far. The mw:Placeholder type alienates the paragraph in VE.

If the VE supports empty p/br paragraphs now we can easily remove the protection, which will make the paragraph editable in VE.

Please reopen when the VE wants the protection to be removed.

I think we want this removed; will check with Roan tomorrow for a final comment.

Confirmed that we want this removed.

Related URL: https://gerrit.wikimedia.org/r/69138 (Gerrit Change I932e4b41de7b665d4c7bb53caf2284c95c794bfe)

https://gerrit.wikimedia.org/r/69138 (Gerrit Change I932e4b41de7b665d4c7bb53caf2284c95c794bfe) | change APPROVED and MERGED [by jenkins-bot]

[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]