Page MenuHomePhabricator

Blocking by "other" doesn't work if the msg 'ipbotheroption' is not "other"
Closed, ResolvedPublic

Description

Author: angus

Description:
In SpecialBlock.php, function showForm(), you create the first block option with

$blockExpiryFormOptions = "<option value=\"other\">$mIpbothertime</option>";

but later, in doSubmit(), you check if it was selected with

if ($expirestr == wfMsg('ipbotheroption'))

I think it should be

if ($expirestr == "other"))

Thanks.


Version: 1.5.x
Severity: major

Details

Reference
bz2953

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:40 PM
bzimport set Reference to bz2953.
bzimport added a subscriber: Unknown Object (MLST).

angus wrote:

(In reply to comment #0)

I think it should be
if ($expirestr == "other"))

...minus the last ")".

brion added a comment.Jul 24 2005, 5:02 PM

This correction has been applied.