Page MenuHomePhabricator

Agora CSS gives labels conflicting styles
Closed, ResolvedPublic

Description

resources/mediawiki.ui/sourcefiles/scss/components/default/_forms.scss gives conflicting CSS for labels. Line 25 specifies

margin: 0;
width: 100%

but then line 39 in the same & > div block specifies

width: auto;
margin: 0 0 0.2em 0;

The later CSS wins according to Firebug.

Perhaps we can just remove label from the first Sass selector. But then the label isn't styled display: block , and AIUI as a result in Firefox it's squeezed tighter to the input field underneath. I think you get identical effective CSS by adding

display: block;
@include box-sizing(border-box);

to the label declaration, but maybe that's overthinking it.


Version: 1.22.0
Severity: normal

Details

Reference
bz47532

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz47532.
bzimport added a subscriber: Unknown Object (MLST).

Related URL: https://gerrit.wikimedia.org/r/60373 (Gerrit Change Ibd36f818865aa5ec99cc187bef983261485966d3)

Related URL: https://gerrit.wikimedia.org/r/60740 (Gerrit Change Ibd36f818865aa5ec99cc187bef983261485966d3)

We went with the fix.