Page MenuHomePhabricator via HTTPS loads resources over HTTP
Closed, ResolvedPublic


When I visit, there are a few resources coming in via HTTP, causing my Web browser to throw warnings.

<img alt="" src="" width="170" height="120" />

<img alt="Wikipedianer auf Exkursion im Kirchenarchiv Kaufbeuren. Foto: Benutzerin:Elya, CC-BY-SA 3.0" src="" width="170" height="128" />

<img alt="Logo von Wikivoyage" src="" width="170" height="180" />

[a bunch of other images ...]

<img src="" alt="Attribution-Share Alike 3.0 Unported" width="88" height="31" />

<img src="" style="border:0" alt=""/>

This is probably the not the best place to report this issue, but I couldn't find a better place and I figured some of the German Wikimedians can be copied on this bug report and can forward this issue as necessary and appropriate.

Version: 1.20.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:37 AM
bzimport set Reference to bz47653.
bzimport added a subscriber: Unknown Object (MLST).

This isn't the right place for this. WMF doesn't host the wiki.

I note Daniel is CC'd on this bug

I have passed on responsibility for this a while ago, but i'll try to poke the relevant people, and help them fix it (I'm pretty sure this was my mistake).

Adding Silke Meyer (who is technically responsible) and Kai Nissen (who has been managing the site).

@sam: WMDE doesn't have a bug tracker for stuff like this, perhaps we could just get a product here?

I'll re-open the bug with the new assignee; if you feel it's really in the way here, close it again. We'll figure out another solution, then.

p858snake: What is "upstream" here???

(In reply to comment #2)

@sam: WMDE doesn't have a bug tracker for stuff like this, perhaps we could
just get a product here?

Please file a separate ticket to discuss this.

The protocol type that has been used to get the file info from gets cached by the parser cache. This will happen vice versa, if the parser caches when requesting with https.

I customized the ForeignAPIRepo for commons to always use the secure protocol when requesting the commons API, but changing ForeignAPIRepo::getThumbUrl() to strip the protocol and make the src attribute protocol-relative seems to be the solution here.

I will provide a patch this weekend.

@MZMcBride: The other images that are not provided by commons were also changed to protocol-relative.

Related URL: (Gerrit Change Id40186d10019a77f8b827a6a67982d40f3e97f11)

(In reply to comment #6)

Patch needs rework.

More than that, Anomie said "Your analysis of the problem in the commit summary is not correct". This bug is indeed misleading and is a duplicate of something the reporter already reported previously and that I had already clarified as bug 48133.

  • This bug has been marked as a duplicate of bug 48133 ***

Change 61390 abandoned by Siebrand:
(bug 47653) Processing foreign API files protocol-relative

I'm abandoning this patch set as it's been open for a long time without any outlook at the open issues being resolved.

If the submitter or anyone else would like to work on it again, this patch set can be re-activated by clicking "Restore Change". Please only do this if you are actually going to work on it immediately.

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:25 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:21 AM