Page MenuHomePhabricator

Tablesorter: colspan in buildHeaders is undefined
Closed, ResolvedPublic

Description

There is a reference to this.colspan there, but it should be this.colSpan and it causes the used colspan to always be 1. This might have some effect on the format detection or something, but I couldn't readily find a testcase that would illustrate that this error has any effect. Requires further investigation.


Version: 1.22.0
Severity: normal

Details

Reference
bz47654

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:37 AM
bzimport added a project: MediaWiki-JavaScript.
bzimport set Reference to bz47654.
TheDJ created this task.Apr 25 2013, 4:44 PM

Is there a testcase where to see this?

TheDJ added a comment.Apr 26 2013, 9:14 AM

"I couldn't readily find a testcase that would illustrate that this error has any effect."

So no. I just noticed it when I copied that code and rewrote it for rowspan only to figure out that the code block wasn't working. I tried finding what would be broken due to this, but was not able to find an issue yet. (possibly the whole block isn't even required ?)

TheDJ added a comment.Jul 6 2013, 3:03 PM

I have rewritten this part of the code in https://gerrit.wikimedia.org/r/71530

Change 71530 had a related patch set uploaded by TheDJ:
Tablesorter: colSpan property was incorrectly accessed

https://gerrit.wikimedia.org/r/71530

Change 71530 merged by jenkins-bot:
Tablesorter: colSpan property was incorrectly accessed

https://gerrit.wikimedia.org/r/71530