Page MenuHomePhabricator

VisualEditor: Trailing whitespace at end of paragraph or table cell dropped on round-trip
Closed, ResolvedPublic

Description

Ubuntu/Firefox
Go to http://en.wikipedia.org/wiki/Alfresco_%28software%29
At the end of a line, add a space and remove it
Click "Save"
No changes should have happen, but there actually are changes, in the infobox:

caption = Alfresco Share / Repository Browser <br/> (Community Edition)

became

caption =Alfresco Share / Repository Browser <br></table> (Community Edition)

Version: unspecified
Severity: major

Details

Reference
bz47712

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz47712.

Other faulty roundtrips:

http://en.wikipedia.org/wiki/Neritina_rubricata
Removes space at end of line

http://en.wikipedia.org/wiki/Timeline_of_portable_computers
--> || becomes -->||

Should I continue reporting space removals like these 2 ones?
Or are these spaces removed on purpose?

This is an instance of the jQuery bug 47737 - marking as a duplicate.

  • This bug has been marked as a duplicate of bug 47737 ***

Do you mean all of the problem mentioned on this page are due to this bug?
Cheers!
Nicolas

I believe the whitespace changes are a separate issue. Reopening so that those don't get lost.

(In reply to comment #4)

Do you mean all of the problem mentioned on this page are due to this bug?

Please open separate bug tickets for each bug in future. :-)

I tested the following 4 pages and am recording my findings here. Once we go through the other pages, we should close this bug and create new bugs where necessary.

On the following two pages, I can reproduce in Firefox, but the edit is clean in Chrome. So, this is definitely Firefox specific, not sure if it is JQuery-related or something else.

On the following two pages, I can reproduce the spurious diffs in both Firefox and Chrome even though I didn't edit the relevant areas. I haven't looked at the diffs yet. So, this is quite likely some kind of whitespace change in the DOM that VE sends Parsoid.

Related URL: https://gerrit.wikimedia.org/r/61919 (Gerrit Change I42daaf142e548e5b221ff0a52df0ad24ec6a4fd0)

We're now three bugs fixed into this stack. Closing. Others should be opened as other bugs.

http://en.wikipedia.org/wiki/Anne_Hendershott still shows the same symptoms. Is this fix not yet deployed?

(In reply to comment #10)

http://en.wikipedia.org/wiki/Anne_Hendershott still shows the same symptoms.
Is
this fix not yet deployed?

Sorry, the meaning of "VE-deploy-2013-05-13" is meant to be pretty clear, but evidently isn't! It'll go out with 1.22wmf4, so on the English Wikipedia on 20 May.