Page MenuHomePhabricator

Adapt "contributors" benefit for different values of $wgActiveUserDays
Closed, ResolvedPublic

Description

The default and recommended value of $wgActiveUserDays is 30. However, if this is different, the third benefit should adapt accordingly.

The magic word NUMBEROFACTIVEUSERS is used in MediaWiki:createacct-benefit-head3. The current text of the corresponding MediaWiki:createacct-benefit-body3 is "contributors this month". This is the part that should output correct text regardless of $wgActiveUserDays. We prefer to keep "this month" if it *is* the default 30-day value.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47693

Details

Reference
bz47753

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz47753.

By the way, "this month" refer to the current month or to the last 30/31 days? For me, it means from the first of the current month until now, so that is already misleading/unclear. Having the days there makes things clearer.

"last 30/31 days".

If you can think of a concise phrase that's clearer than "this month", we'll consider it.

*IF*

            28,983
contributors in the last 30 days

is the right thing to display by default, we can do so and dynamically adjust for the wiki's $wgActiveUserDays. It is more accurate and clearer, but I imagine this phrase gets even wordier in other languages.

Related URL: https://gerrit.wikimedia.org/r/61165 (Gerrit Change I526bfbb99c45f15dc78396da9a488a09bbf09baa)

Hmm. The other two benefits are one word in English, and this is five. It's also a little more clinical.

I would prefer we use something shorter for the 30-day case, either "contributors this month" (a little vague, but I don't know if it's a real problem) or "contributors in the last month" (only a little shorter than the 30 day version).

Why not "recent contributors"? Is the timeframe important? :-)

"Recent contributors" is worth considering.

swalling wrote:

(In reply to comment #7)

"Recent contributors" is worth considering.

+1. I think that's better. Let's do it.

Related URL: https://gerrit.wikimedia.org/r/61246 (Gerrit Change Ic3a9bf025cca338218a7dde2fe02d0409d3db2d5)

That proposed change is for all cases, including the 30-day case. Steven, correct me if that's not what you meant.

The "recent contributors" change was merged. Since that isn't a specific timeframe, no further adaptation is necessary.