Page MenuHomePhabricator

Move Thanks-specific code to Thanks extension
Closed, ResolvedPublic

Description

There's some code that is only used for Thanks in the Echo extension. I am aware of:

  1. mw-echo-icon-gratitude (GettingStarted resolves this by having its own Echo stylesheet for this).
  2. Option set for echo-subscriptions-email-edit-thank in Echo Hooks.php

Fixing this will provide a better example of how to extend Echo, and help maintainability and separation of concerns.


Version: master
Severity: normal

Details

Reference
bz47757

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz47757.
bzimport added a subscriber: Unknown Object (MLST).

The gratitude icon isn't Thanks specific (it was actually originally intended for the WikiLove notification which hasn't been built). The part in Hooks.php should be removed though.

Related URL: https://gerrit.wikimedia.org/r/61151 (Gerrit Change Ia8be4967d962176f1e58ee6488f4cc9bfe75b655)

Related URL: https://gerrit.wikimedia.org/r/61152 (Gerrit Change I1aa81cf81ca71af323f0d5448fb5800086a09b1e)

Related URL: https://gerrit.wikimedia.org/r/61156 (Gerrit Change I2a574ebe530a2bb37b85155220f14f999a639587)

The only remaining reference seems to be the Gratitude icon, so this is fixed.