Page MenuHomePhabricator

possibles errors of action=createaccount depending on uselang and changed when message is modified onwiki
Closed, ResolvedPublic

Description

The errors, shown by action=paraminfo for a module are usally in english and does not depending on wiki modified messages, because there are hardcoded inside the api.

This is not happen for some of the errors of the action=createaccount module, which makes things bad, because the return result contains mixed languages, very bad.


Version: 1.22.0
Severity: normal

Details

Reference
bz47791

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:17 AM
bzimport set Reference to bz47791.

I don't quite understand what you're talking about. Could you show an example API response which is wrong?

Go to

http://de.wikipedia.org/w/api.php?action=paraminfo&modules=createaccount&format=jsonfm

Search for "errors"

You will see some english text and by "wrongpassword" a german text.

For message "acct_creation_throttle_hit" you can see, that there is the locally created message is used ([[de:MediaWiki:acct_creation_throttle_hit]])

All other modules (for example modules=edit) response only a english text. The error messages of that module on action=createaccount are also not in english, action=edit always response error text in english.

Should be easy to fix, if someone wants to bother. Just chain ->inLanguage( 'en' )->useDatabase( false ) onto the wfMessage() calls.

See also bug 45843.

Change 75081 had a related patch set uploaded by Legoktm:
Possible error messages for action=createaccount should be in English and not show local modifications

https://gerrit.wikimedia.org/r/75081

Change 75081 merged by jenkins-bot:
Possible error messages for action=createaccount should be in English and not show local modifications

https://gerrit.wikimedia.org/r/75081

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM