Load local Geshi.css in module namespace
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	duplicatebug
	Apr 28 2013, 6:17 PM

Description

Code in the module namespace is highlighted with Geshi (at least on wmf wikis), but the local MediaWiki:Geshi.css is not loaded, so local changes there for the lua language have no effects to the highlighting.

Version: unspecified
Severity: minor

Details

Reference: bz47798

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:18 AM

• bzimport added a project: Scribunto.

• bzimport set Reference to bz47798.

• bzimport added a subscriber: Unknown Object (MLST).

duplicatebug created this task.Apr 28 2013, 6:17 PM

Why does SyntaxHighlight_GeSHi::buildHeadItem() not handle this, I wonder, considering that it handles the rest of the GeSHi CSS bits. Or else SyntaxHighlight_GeSHi should provide another static method to handle it, so other extensions don't have to know about SyntaxHighlight_GeSHi's ResourceLoader modules and whatever checks it does to decide when to load it.

duplicatebug unsubscribed.Dec 13 2014, 4:44 PM

This is fixed in Wikia's version of Scribunto by https://github.com/Wikia/app/commit/dcdccd1dbe3493d3539a963c980fdf94565329fa and based on that would appear to be fixed by http://git.wikimedia.org/commit/mediawiki%2Fextensions%2FScribunto/c44d576b78ef3c03fe33a593e0e8fab07c943e99 as well. Can anyone confirm if this bug is still valid?

This does appear to be resolved, likely by the linked change.

I confirmed this works at
https://pt.wikibooks.org/wiki/Module:String
with
https://pt.wikibooks.org/wiki/MediaWiki:Geshi.css?diff=276854&oldid=172197

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:43 PM

Load local Geshi.css in module namespaceClosed, ResolvedPublicActions

Description

Details

Event Timeline

Load local Geshi.css in module namespace
Closed, ResolvedPublic
Actions