Page MenuHomePhabricator

Thread title containing "</div>" destroys entire page with $wgUseTidy = true
Closed, InvalidPublic

Description

Screenshot of LQT thread with </div> in title

Should be treated the same as regular page titles: Escape everything.

Or, if we want to keep wikitext parsing (e.g. for wikilinks, sometimes done in section headings), then parse as inline block (not allowing any block level elements like <div> or <table>) and make sure open/close tags match (run Tidy).


Version: unspecified
Severity: major
URL: https://www.mediawiki.org/wiki/Thread:Project:Support_desk/visible_html_on_pages%3A
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=31244
https://bugzilla.wikimedia.org/show_bug.cgi?id=29564

Attached:

Screen_Shot_2013-04-30_at_6.40.53_PM.png (1×2 px, 513 KB)

Details

Reference
bz47885

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:24 AM
bzimport set Reference to bz47885.
bzimport added a subscriber: Unknown Object (MLST).

@Krenair: You change the summary to include "with wgUseTidy = true;" Are you saying that when Tidy is disabled this bug does not happen?

Seems more like the opposite?

(In reply to comment #1)

@Krenair: You change the summary to include "with wgUseTidy = true;" Are you
saying that when Tidy is disabled this bug does not happen?

Yes. I have to add that to my configuration to replicate this bug.

This is one of the many places with poor or inconsistent escaping in LQT.

A similar problem in a topic named "Handling <pre><ref></pre> with trailing slash does not work correctly":
https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Handling_ref_with_trailing_slash_does_not_work_correctly

Jdforrester-WMF lowered the priority of this task from High to Lowest.Aug 4 2016, 11:34 PM
Jdforrester-WMF subscribed.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to High.Aug 5 2016, 7:34 AM

Suggest decline this task, such problem are mostly from PHP which is a bit more Upstream ed