Page MenuHomePhabricator
Create Task
Maniphest T49999

Echo: incorrectly parses section headings with wikimarkup in them.
Closed, ResolvedPublic
Actions

Description

Screenshot

See associated screenshot.

Version: master
Severity: normal

Attached:

NJ8SglP.png (94×597 px, 5 KB)

Details

Reference
bz47999

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:32 AM
• bzimport added a project: Notifications (Echo).
• bzimport set Reference to bz47999.
Ironholds created this task.May 2 2013, 2:32 PM
gerritbot added a comment.May 2 2013, 11:21 PM

Related URL: https://gerrit.wikimedia.org/r/62110 (Gerrit Change Id295c1)

kaldari added a comment.May 3 2013, 12:12 AM

We probably want to change the regex in NotificationFormatter.php line 148...
!(.*)/\*\s*(.*?)\s*\*/(.*)!
...to match what's in Linker::formatLinksInComment().

kaldari added a comment.May 3 2013, 12:28 AM

Oh, didn't see that Benny already checked in a patch. Will review...

EBernhardson added a comment.May 21 2013, 2:50 PM

Bug fix Merged as of May 10th

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits