Page MenuHomePhabricator

VisualEditor: Indenting multiple list items now broken in Firefox
Closed, ResolvedPublic

Description

Multiple list items don't indent properly.

Steps to duplicate the bug:

Write a couple of lines. Mark all the lines and click the "list" button - producing bullet-list.

If the indent button is clicked when the cursor is on a single list item, that item will be indented. However, if you mark a couple of list items and indent them at once, the indentation is jumbled: some of the items are indented and some double-indented (and the item above the selection seems to be indented as well)


Version: unspecified
Severity: normal

Details

Reference
bz48069

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:37 AM
bzimport set Reference to bz48069.

Broken in master for Firefox but not in wmf3 - presumably we changed something in the last week that did this?

I am entirely not sure if I am in the right direction here, but I figured I'd share my intuition --

I am thinking this is some bug with the definition of child-nodes vs same-level nodes, which results in indentation as if some of the nodes selected are parents.

There was a change in ve.ce.BranchNode.js and ve.ce.ContentBranchNode.js regarding child nodes -- could this have caused it?

+ve.ce.BranchNode.prototype.onModelUpdate = function ( transaction ) {
+ this.emit( 'childUpdate', transaction );

And there are a couple of other changes in the ve.ce.BranchNode.prototype.onSplice method. Perhaps something went wrong with the definition of what is a child and what is a same-level node, which then jumbles up the hierarchy of the list?

(I do hope I am in the right direction here, I thought I'd share my thoughts)

  • This bug has been marked as a duplicate of bug 48390 ***