Page MenuHomePhabricator

action=setnotificationtimestamp throws fatal error when parameters for the page are missing
Closed, ResolvedPublic

Description

Calling action=setnotificationtimestamp with parameter newerthanrevid set to the most recent revision throws a fatal error:

PHP fatal error in /usr/local/apache/common-local/php-1.22wmf2/includes/api/ApiSetNotificationTimestamp.php line 78:

Call to a member function getNextRevisionID() on a non-object

Expected result: The notification timestamp should be reset, as this means that the user has viewed all revisions of that page.


Version: 1.22.0
Severity: normal

Details

Reference
bz48071

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz48071.
Schnark created this task.May 4 2013, 7:11 AM

I should read the documentation first...
Repurposing this bug: When neither titles, nor pageids, nor revids, nor entierwatchlist are specified, no fatal error should be thrown, but instead a helpful error message about the fact that at least one of these parameters is required.

Related URL: https://gerrit.wikimedia.org/r/62229 (Gerrit Change I5abcdf0fa20486f1198d1cc111461b3088a311df)

Change 62229 merged by jenkins-bot:
API: Fix setnotificationtimestamp with no pages given

https://gerrit.wikimedia.org/r/62229

Anomie added a comment.Jul 1 2014, 7:40 PM

Should be deployed to WMF wikis with 1.24wmf12, see https://www.mediawiki.org/wiki/MediaWiki_1.24/Roadmap for the schedule.