Page MenuHomePhabricator

action=setnotificationtimestamp throws fatal error when parameters for the page are missing
Closed, ResolvedPublic


Calling action=setnotificationtimestamp with parameter newerthanrevid set to the most recent revision throws a fatal error:

PHP fatal error in /usr/local/apache/common-local/php-1.22wmf2/includes/api/ApiSetNotificationTimestamp.php line 78:

Call to a member function getNextRevisionID() on a non-object

Expected result: The notification timestamp should be reset, as this means that the user has viewed all revisions of that page.

Version: 1.22.0
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:37 AM
bzimport set Reference to bz48071.

I should read the documentation first...
Repurposing this bug: When neither titles, nor pageids, nor revids, nor entierwatchlist are specified, no fatal error should be thrown, but instead a helpful error message about the fact that at least one of these parameters is required.

Related URL: (Gerrit Change I5abcdf0fa20486f1198d1cc111461b3088a311df)

Change 62229 merged by jenkins-bot:
API: Fix setnotificationtimestamp with no pages given

Should be deployed to WMF wikis with 1.24wmf12, see for the schedule.