Installer sets $wgLogo default path incorrectly
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• brooke
	May 4 2013, 8:37 PM

Description

Freshly installed MW from git.

My LocalSettings.php contains:
$wgLogo = "/wiki/skins/common/images/wiki.png";

This path doesn't exist -- I installed in /core not in /wiki.

Version: 1.22.0
Severity: normal

	Subject	Repo	Branch	Lines +/-
	installer: Write to wgLogos, not wgLogo	mediawiki/core	REL1_35	+21 -10
	installer: Write to wgLogos, not wgLogo	mediawiki/core	master	+21 -10

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:38 AM

• bzimport set Reference to bz48084.

• bzimport added a subscriber: Unknown Object (MLST).

Probably caused by Ia6efdf93, which implemented the feature of customizing the logo in the installer. CC-ing committer.

Apparently this only happens if you select "I'm bored already, just install the wiki.".

Change 85959 had a related patch set uploaded by PleaseStand:
Installer: properly override default $wgLogo value

Patch merged, marking as fixed.

Backported to REL1_23 in gerrit changeset 133458

Tested on a REL1_23 downloaded from git

Change 575293 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/core@master] installer: Write to wgLogos, not wgLogo

Change 575293 merged by jenkins-bot:
[mediawiki/core@master] installer: Write to wgLogos, not wgLogo

Change 616982 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_35] installer: Write to wgLogos, not wgLogo

Change 616982 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Write to wgLogos, not wgLogo