Page MenuHomePhabricator

EditEntity (API) refactoring
Closed, ResolvedPublic

Description


Version: unspecified
Severity: normal

Details

Reference
bz48137

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:42 AM
bzimport set Reference to bz48137.
bzimport added a subscriber: Unknown Object (MLST).
Abraham created this task.May 6 2013, 10:03 AM

The EditEntity API module needs refactoring. Two steps are suggested:

  1. Factor individual modifications (like set lable, remove alias) into ChangeOp classes (similar to, maybe even compatible to DiffOp). besides modifying the entity, they should faciliate the creation of summaries and permission checks.
  1. Move the module's logic into a handler/controller. That controller may be aware of the API, especially of the Request and Result objects. Isolation from that knowledge would be nice, but is not essential at the moment.

Related URL: https://gerrit.wikimedia.org/r/66392 (Gerrit Change Id9146d20893f300a66b377f96bf85dc709e3d022)

Related URL: https://gerrit.wikimedia.org/r/66981 (Gerrit Change Ic27774f67f8728acbb48cbf945fda063791096cf)

Related URL: https://gerrit.wikimedia.org/r/68378 (Gerrit Change I8666bbad10595237ae89fcaf9f0f649656951037)

Verified in Wikidata demo time July 17th