Page MenuHomePhabricator

Section level editing surfaced on mobile sites
Closed, ResolvedPublic


In the section headings for and the edit link is being printed when it shouldn't be. Previously these links were wrapped in a span with class editsection now this class has been renamed to mw-editsection (I'm not sure why it wasn't renamed to mw-edit-section or removed completely but that's another discussion)

These should be removed until a nicer editing experience is provided.

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:43 AM
bzimport set Reference to bz48153.

That's bug 41729 / change I6a6c12a9 and it has been preceded by a long code-review process and numerous announcements on the wikis and technical lists.

Why would you want to remove the class? It's obviously the way to style those links, and apparently it's been used by MF to hide them.

I missed the numerous announcements and code review - I wasn't doubting that it happened I just found the outcome strange (albeit without knowing the history) as you can obviously style links inside headings without need of a class... but as I stated that's another discussion.

For MobileFrontend we'll just need to update the formatter to strip these as well for the time being until we have section level editing.

You can have regular links in headings as well. (Does MF not support this? I'd call it a bug.)

And the section edit links are wrapped in brackets, which one would want to hide or style as well.

Related URL: (Gerrit Change I46540eff3d01824cd304c10aa3806d17e1fa00d1)

Well in mobile we don't need to worry about legacy support and can use css3 selectors (last-child) - in terms of [ and ] that's what ::before and ::after are for :) - another reason for making edit links part of the skin rather than in the content (see Rethinking MobileFormatter / Skins wikitech email).

Anyway fixes it for MobileFrontend

You can also have headings without section edit links. So yes, the class *is* needed. And I *did* think that change through. (Gerrit Change I46540eff3d01824cd304c10aa3806d17e1fa00d1) | change APPROVED and MERGED [by jenkins-bot]