Page MenuHomePhabricator

Defaults override event properties
Closed, ResolvedPublic

Description

Because of the order of parameters in the call to extend, the schema defaults override the event's values.

The normal meaning of default would imply the reverse.

I don't know if this can be changed at this point. If not, the docs should warn you about it.


Version: unspecified
Severity: normal

Details

Reference
bz48248

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:20 AM
bzimport set Reference to bz48248.
ori added a comment.May 8 2013, 7:55 AM

First of all: wow. Good catch. I don't know how this slipped past -- it is egregious.

It looks like we may be saved by the fact that setDefaults was not advertised well and thus not used outside of E3: GuidedTour and GettingStarted are the only instances of setDefault use in the wild that I have been able to identify.

GuidedTour is okay, since it only uses it for userId and it never overrides that (nor would it make sense too).

Related URL: https://gerrit.wikimedia.org/r/62793 (Gerrit Change Id14ba276329272c41370458d5330599a725f5419)

Gerrit change is live.

[moving from MediaWiki extensions to Analytics product - see bug 61946]