Page MenuHomePhabricator

Site links on Special:MergeAccount all link to same domain
Closed, ResolvedPublic

Description

All the site links on Special:MergeAccount:
https://login.wikimedia.org/w/index.php?title=Special:MergeAccount

link to my user page on login.wikimedia.org. They should link to the sites they are listing, eg 'en.wikipedia.org' or 'sc.wiktionary.org' etc.


Version: unspecified
Severity: normal
URL: https://login.wikimedia.org/w/index.php?title=Special:MergeAccount

Details

Reference
bz48264

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:21 AM
bzimport set Reference to bz48264.
brion created this task.May 8 2013, 5:43 PM
Reedy added a comment.May 8 2013, 5:49 PM

Line 459 onwards of SpecialMergeAccount.php is at fault

See 466 where it's always a local title object:

		$userPageName = Title::makeTitleSafe( NS_USER, $this->mUserName );
		return Xml::element( 'a',
			array(
				'href' => $userPageName->getFullUrl(),
				'title' => $this->msg( 'centralauth-foreign-link',
					$this->mUserName,
					$hostname )->text(),
			),
			$hostname );
Reedy added a comment.May 8 2013, 5:50 PM

Vs SpecialCentralAuth.php

		$wikiname = $wiki->getDisplayName();
		return $this->foreignLink(
			$wiki,
			'User:' . $this->mUserName,
			$wikiname,
			$this->msg( 'centralauth-foreign-link', $this->mUserName, $wikiname )->text() );

Related URL: https://gerrit.wikimedia.org/r/62839 (Gerrit Change If2c59da4342e0a149b775b4588353eff0106a708)

Caused by Gerrit change 52337

Fixed in master by Reedy's code.