Page MenuHomePhabricator

VisualEditor: Round-trip failures
Closed, ResolvedPublic

Description

Bad diff from VisualEditor on mediawiki.org, 2013-05-13

Go to https://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals. Click "edit". VisualEditor form loads. Add a space after the sentence "that drive editor engagement;". Remove the space. Click "Review and save".

Expected behavior: a diff showing no changes at all (space was added to the end of the line and then removed).

Current behavior: see attached screenshot.


Version: unspecified
Severity: normal

Attached:

ve-diff.png (869×2 px, 101 KB)

Details

Reference
bz48427

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:32 AM
bzimport set Reference to bz48427.

I played around a bit locally while on the plane and tried to reproduce on master from the screenshot. I didn't reproduce your bug, but I found bug 48605 instead. Now that I have an internet connection again, I'll take a proper look at this bug once I've caught up on sleep.

(In reply to comment #1)

I played around a bit locally while on the plane and tried to reproduce on
master from the screenshot.

Blergh. I can still definitely reproduce this issue on mediawiki.org following the steps in comment 1.

Are Parsoid/VisualEditor versions exposed somewhere? Or alternately, is there a public wiki running the most up-to-date version of VisualEditor? I really don't like wasting my time filing bugs that no longer exist. :-/

(In reply to comment #2)

Are Parsoid/VisualEditor versions exposed somewhere?

[[mw:Special:Version]] :-) In general, VisualEditor is branched for production at the same time as MediaWiki core right now (so, fortnightly for the rest of this month, thereafter weekly); Parsoid is updated in production more frequently but less regularly, as it's a manual process.

Or alternately, is there a public wiki running the most up-to-date version
of VisualEditor?

No, I don't think so (but isn't beta meant to run master of everything?). Perhaps I should make a bug to build one in Labs.

I really don't like wasting my time filing bugs that no longer exist. :-/

The perils of testing software that gets a dozen or so bugs fixed each week, sadly. In this particular case, I'm assuming that it's a Parsoid bug that was fixed (as I can't see anything in our git log that would suggest a VE fix changing this behaviour). Sorry!

Seems to have been fixed since the filing of this bug. Can you still reproduce this?

We did a bunch of changes to avoid dirty-diffs with Parsoid; though there may be a few outstanding, I think we've got most of them licked, so closing.