Page MenuHomePhabricator

VisualEditor: [Regression] Link inspector button doesn't work
Closed, ResolvedPublic

Description

  1. Create a link using the link inspector button
  2. Note that autocomplete feature doesn't appear
  3. Hit save and note that link is stored as an external link "[Foo Foo]"

Using the keyboard shortcut, however, works fine (Ctrl+K)


Version: unspecified
Severity: normal

Details

Reference
bz48509

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:38 AM
bzimport set Reference to bz48509.

Looks like the format for providing toolbar options was changed, so the MW override isn't working. As a result we're rendering a link button instead of an mwLink. Ctrl+K works because the mwLink is still registered with the command registry (should commands work without the button being rendered?)

Related URL: https://gerrit.wikimedia.org/r/63850 (Gerrit Change Icda3305e422bedaf0d490b8fbe51f55b8c8e79e8)

Merged into master; will go out with wmf5.