Page MenuHomePhabricator
Create Task
Maniphest T50581

refactor upload code a bit for use with extensions
Open, LowPublicFeature
Actions

Description

I'm thinking of developing a new version of Extension:MultiUpload and using it as a base for a more specialized upload interface for another extension's use. All this (including the current MultiUpload) would work better if there were more of a distinction in the code between the Special:Upload page and its HTTP request, and a single file-upload operation, since you need that distinction in order to do multiple file uploads in a single request.

I'd like to split up a few functions in SpecialUpload.php, upload.js, and UploadBase.php, so that they don't assume a single upload per page view and can be called more flexibly. I'm working on a prototype, which I'll put into Gerrit when it's more ready.

I'm opening this bug now in case people want to discuss it.

Version: 1.22.0
Severity: enhancement

Details

Reference
bz48581

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:43 AM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz48581.
• bzimport added a subscriber: Unknown Object (MLST).
Worden.lee created this task.May 17 2013, 5:42 PM
Aklapper added a comment.May 24 2013, 2:51 PM

Mentioning it in a thread on https://lists.wikimedia.org/mailman/listinfo/wikitech-l might be good.

Bawolff added a comment.May 24 2013, 7:08 PM

I agree that the upload classes could be refactored (in particular trying to fix bug 48306 revealed some weaknesseses with the current design)

Worden.lee added a comment.May 24 2013, 8:12 PM

Sure. I probably won't touch those parts. I think a MultiUpload page - that is, an interface like Special:Upload but with several copies of the upload-file interface on a single page - can be done using a SpecialPage object that derives from SpecialUpload and a list of objects of SpecialUploadOneFile class that also derives from SpecialUpload - if some of SpecialUpload's functions are split so they can be selectively replaced in the subclasses. This is a kind of odd design, but would allow it to use Special:Upload's code with almost no duplication while making minimal changes to MW core. Some similar splitting would also need to happen in the javascript, and a more general factory function for UploadBase.

Aklapper added a comment.Mar 10 2014, 11:10 AM

https://gerrit.wikimedia.org/r/#/c/67173/

• Gilles added a project: Multimedia.Nov 24 2014, 3:11 PM
Krinkle added a project: Technical-Debt.Dec 10 2014, 2:03 PM
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:12 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:12 PM
Danny_B moved this task from Unsorted to Needs refactor on the Technical-Debt board.Jan 23 2016, 12:06 AM
Restricted Application added a project: Commons. · View Herald TranscriptJan 23 2016, 12:06 AM
Steinsplitter moved this task from Incoming to Backlog on the Commons board.Feb 13 2016, 5:36 PM
Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL