Page MenuHomePhabricator

changing a Snak's time value from a valid to an invalid one will not disable Claim's "save" button
Closed, ResolvedPublic

Description

Changing a "time" value from a valid to an invalid value will not trigger the "save" button to be disabled. When saving, the previously valid value will be saved.

The reason for this is that the jQuery.valueview.experts.TimeInput instance won't notify about the change from valid to invalid. Probably because the jQuery.time.timeinput's "update" event only triggers when the value changes to another valid value.

Note: this should be a bug in the "ValueView" extension which is not yet available in bugzilla.


Version: unspecified
Severity: normal

Details

Reference
bz48621

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:17 AM
bzimport set Reference to bz48621.
bzimport added a subscriber: Unknown Object (MLST).
Danwe created this task.May 19 2013, 9:55 PM

Update: the "update"/"change" events/notifications get passed along well. The rawValue() of the expert is the problem. It always remains the same, even if it should reflect the invalid value and not return a time value.

Within the expert's _getRawValue(), this._newValue is 'undefined' even though it should be 'false' in the case described above. Not sure how this could happen. If it were 'false', the right value would be returned.

Related URL: https://gerrit.wikimedia.org/r/64541 (Gerrit Change Ieb37ba7ea544c37421e38ddef21acef901b26523)

https://gerrit.wikimedia.org/r/64541 (Gerrit Change Ieb37ba7ea544c37421e38ddef21acef901b26523) | change APPROVED and MERGED [by jenkins-bot]

Verified in Wikidata demo sprint 22-5