Page MenuHomePhabricator

JavaScript UI fails if entity page data model contains unexpected DataValues JSON
Closed, ResolvedPublic

Description

If on an entity page the JSON representing the entity contains some unexpected values in a Snak's DataValues JSON, the UI will fail to initialize.

This can be the case for various reasons. Currently it is the case for Time values where the JSON contains an unknown calendar model. Since the backend doesn't check for known calendar models, it is easy to inject such data via the API.
The Frontend should not fail but rather display a warning that a value was not successfully unserialized.


Version: unspecified
Severity: normal
Whiteboard: Storypoints: 5

Details

Reference
bz48622

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:17 AM
bzimport set Reference to bz48622.
bzimport added a subscriber: Unknown Object (MLST).
Danwe created this task.May 19 2013, 11:53 PM

Related URL: https://gerrit.wikimedia.org/r/64543 (Gerrit Change I4dba21975c6592050167f527c9dddcc734df9041)

Related URL: https://gerrit.wikimedia.org/r/64545 (Gerrit Change I4f9215add1f3e964f229cbe222e9b0562045648d)

https://gerrit.wikimedia.org/r/64543 (Gerrit Change I4dba21975c6592050167f527c9dddcc734df9041) | change APPROVED and MERGED [by jenkins-bot]

https://gerrit.wikimedia.org/r/64545 (Gerrit Change I4f9215add1f3e964f229cbe222e9b0562045648d) | change APPROVED and MERGED [by jenkins-bot]

Verified in Wikidata demo sprint 22-5