Page MenuHomePhabricator

SpecialWatchlist and SpecialRecentChanges have too much duplicated divergent code
Closed, ResolvedPublic


SpecialWatchlist should extend SpecialRecentChanges. This has already been done for SpecialRecentchangeslinked back in 2008 in r36682, it should be pretty straightforward (but extremely boring) to do it for Watchlist, too.

Another commit to look at for inspiration might be r36376 (SpecialRecentChanges refactoring).

Version: 1.22.0
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:18 AM
bzimport set Reference to bz48641.

Assigning to Brion 'cause he let that mess happen back in 2003. :P

Related URL: (Gerrit Change I0fcc95850aa13ea7f4b5a4fdcfddb8ca6b66bf88)

(That URL isn't really related.)

I am working on this, will link patches here when I have something worth looking at.

Change 89379 had a related patch set uploaded by Bartosz Dziewoński:
Make SpecialWatchlist extend SpecialRecentChanges: step 1

That is just the first commit of a multi-commit stack. There are currently 8 commits, the latest being , and I will probably submit some more.

Change 89379 merged by jenkins-bot:
Make SpecialWatchlist extend SpecialRecentChanges (temporarily)

Bartosz: status update? :-) Are there still patches to review?

More could be done (the code has a few @todos left), but the bulk of work has been completed. Good job, me!