Page MenuHomePhabricator
Create Task
Maniphest T50641

SpecialWatchlist and SpecialRecentChanges have too much duplicated divergent code
Closed, ResolvedPublic
Actions

Description

SpecialWatchlist should extend SpecialRecentChanges. This has already been done for SpecialRecentchangeslinked back in 2008 in r36682, it should be pretty straightforward (but extremely boring) to do it for Watchlist, too.

Another commit to look at for inspiration might be r36376 (SpecialRecentChanges refactoring).

Version: 1.22.0
Severity: enhancement

Details

Reference
bz48641

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 1:18 AM
• bzimport added projects: MW-1.23.0-release, MediaWiki-Watchlist.
• bzimport set Reference to bz48641.
matmarex created this task.May 20 2013, 4:25 PM
matmarex added a comment.May 20 2013, 4:30 PM

Assigning to Brion 'cause he let that mess happen back in 2003. :P

gerritbot added a comment.May 20 2013, 6:58 PM

Related URL: https://gerrit.wikimedia.org/r/64615 (Gerrit Change I0fcc95850aa13ea7f4b5a4fdcfddb8ca6b66bf88)

matmarex added a comment.Jul 24 2013, 10:02 AM

(That URL isn't really related.)

matmarex added a comment.Nov 8 2013, 12:12 AM

I am working on this, will link patches here when I have something worth looking at.

gerritbot added a comment.Nov 10 2013, 8:48 PM

Change 89379 had a related patch set uploaded by Bartosz Dziewoński:
Make SpecialWatchlist extend SpecialRecentChanges: step 1

https://gerrit.wikimedia.org/r/89379

matmarex added a comment.Nov 10 2013, 8:49 PM

That is just the first commit of a multi-commit stack. There are currently 8 commits, the latest being https://gerrit.wikimedia.org/r/94677 , and I will probably submit some more.

gerritbot added a comment.Dec 31 2013, 9:41 AM

Change 89379 merged by jenkins-bot:
Make SpecialWatchlist extend SpecialRecentChanges (temporarily)

https://gerrit.wikimedia.org/r/89379

• MZMcBride added a comment.Jan 20 2014, 7:47 AM

Bartosz: status update? :-) Are there still patches to review?

Legoktm added a comment.Jan 20 2014, 7:49 AM

https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:watchlist,n,z

matmarex added a comment.Mar 19 2014, 10:48 AM

More could be done (the code has a few @todos left), but the bulk of work has been completed. Good job, me!

Isarra added a comment.Mar 19 2014, 5:27 PM

Good job, you!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL