Page MenuHomePhabricator

Upgrade CSV query printer to allow for specification of output filename
Closed, ResolvedPublic

Description

Author: patelmm79

Description:
modified query printer CSV for specifying filename

Hello--for CSV query printer, I think it would be a nice feature to allow for specification of output filename (as is done for DSV).

I've tried to do as such, replicating the code from the DSV query printer (I am a novice though, so probably need some review). See attached.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz48757

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:26 AM
bzimport set Reference to bz48757.
bzimport added a subscriber: Unknown Object (MLST).
Unknown Object (User) added a comment.May 23 2013, 9:42 PM

You might consider to apply the patch directly to the continues integration environment Gerrit/Jenkins [1], [2] otherwise it will take time before the patch gets reviewed and/or is deployed with SMW itself.

Thanks

[1] http://www.mediawiki.org/wiki/Developer_access

[2] http://www.mediawiki.org/wiki/Gerrit/Tutorial

I would note that we can also accept changes on Github [1]
and migrate them to Gerrit using SuchABot [2]

[1] https://github.com/wikimedia/mediawiki-extensions-SemanticMediaWiki
[2] https://github.com/yuvipanda/SuchABot

We also have a DSV result format which may profit from such an enhancement, too. However I am not sure if it is already in place there or not.

Change 71085 had a related patch set uploaded by Mwjames:
\SMW\CsvResultPrinter add filename parameter

https://gerrit.wikimedia.org/r/71085

Change 71085 merged by jenkins-bot:
\SMW\CsvResultPrinter add filename parameter

https://gerrit.wikimedia.org/r/71085