Page MenuHomePhabricator

new edits to course pages do not create entries in page history
Closed, ResolvedPublic

Description

Currently, creating or editing a course page does not create a new entry in the page history. For recently created course pages, there are no entries at all in the page history. For example, https://en.wikipedia.org/w/index.php?title=Education_Program:Peer_to_Peer_University/Writing_Wikipedia_Articles_(2013_Q2)&action=history

For earlier course pages, the history remains for previous revisions, but new edits do not create new history entries. For example, today I edited this page: https://en.wikipedia.org/wiki/Education_Program:Example_University/Example_Course_(2013_Q1)


Version: master
Severity: critical

Details

Reference
bz48782

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:28 AM
bzimport set Reference to bz48782.
Ragesoss created this task.May 24 2013, 2:17 PM

Think I found the issue - some very important method is no longer getting called due to changes in core. Leaky abstractions do indeed sink software...

Should be fixed by https://gerrit.wikimedia.org/r/#/c/66023/

Though it seems there are other issues around as well...

What changes in core?

What changes in core?

The last ones I made to ORMRow. So my fault, twice :)

Not sure if it's the same bug, but when I try to click the history button on a page I recently created on he.wiki, I get a server error ( PHP fatal error in /usr/local/apache/common-local/php-1.22wmf7/includes/db/ORMTable.php line 924:
Argument 1 passed to ORMTable::newRow() must be an array, string given, called in /usr/local/apache/common-local/php-1.22wmf7/extensions/EducationProgram/includes/rows/EPRevision.php on line 50 and defined )

This is the page: http://he.wikipedia.org/wiki/%D7%94%D7%95%D7%A8%D7%90%D7%94:%D7%90%D7%95%D7%A0%D7%99%D7%91%D7%A8%D7%A1%D7%99%D7%98%D7%AA_%D7%97%D7%99%D7%A4%D7%94/%D7%9E%D7%A1%D7%93%D7%99_%D7%A0%D7%AA%D7%95%D7%A0%D7%99%D7%9D_%282013_%D7%90%27%29

Tomer, what you ran into is the related bug 49971. We have a patch for it awaiting code review and deployment; it should be fixed soon.

(In reply to comment #6)

Tomer, what you ran into is the related bug 49971. We have a patch for it
awaiting code review and deployment; it should be fixed soon.

Thanks.