Page MenuHomePhabricator

Various submodules in mediawiki/extensions are not being automatically updated
Closed, ResolvedPublic

Description

I updated the translations of several VisualEditor messages in translatewiki.net. The changes were committed to Gerrit, and it looks like LocalisationUpdate ran several times since then, but I still don't see them on the Hebrew Wikipedia.

For example, let's take the message Visualeditor-linkinspector-suggest-matching-page:

  1. Update in transatewiki.net: https://translatewiki.net/w/i.php?title=MediaWiki%3AVisualeditor-linkinspector-suggest-matching-page%2Fhe&diff=4721642&oldid=4682586
  1. Commit to Gerrit: https://gerrit.wikimedia.org/r/#/c/63552/1/VisualEditor.i18n.php (line 1661)
  1. Still not updated in he.wikipedia: https://he.wikipedia.org/w/index.php?title=Special:AllMessages&prefix=visu&filter=modified&lang=he&limit=5000

Version: wmf-deployment
Severity: normal

Details

Reference
bz48893

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:36 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz48893.
bzimport added a subscriber: Unknown Object (MLST).

The problem seems to be that the VisualEditor submodule in mediawiki/extensions hasn't been being automatically updated for some reason.

We'll see if gerrit change 65818 (manually updating the submodule to master) will convince the automatic updating to start working again.

(In reply to comment #1)

We'll see if Gerrit change #65818 (manually updating the submodule to master)
will convince the automatic updating to start working again.

It didn't.

Also, I did some further checking and found some other submodules also affected. The full list is: EImage MagicNoCache MyVariables NamespaceRelations OpenStreetMapSlippyMap PHPExcel PerPageLicense TimelineTable VisualEditor

It'll probably take someone either checking Gerrit's logs or digging through Gerrit's code to find out what exactly is making it not update these modules.

(In reply to comment #0)

For example, let's take the message
Visualeditor-linkinspector-suggest-matching-page:

That one arrived.

(In reply to comment #2)

Also, I did some further checking and found some other submodules also
affected. The full list is: EImage MagicNoCache MyVariables
NamespaceRelations
OpenStreetMapSlippyMap PHPExcel PerPageLicense TimelineTable VisualEditor

I don't know if it's related, but the most obvious place where I saw recent changes being unreported is https://github.com/wikimedia/mediawiki-extensions which at some point reported a bunch of extensions as last edited "6 months ago" when they obviously weren't.

So VisualEditor was fixed with some manual database poking, and a number of the others seem to have been fixed too. Thanks ^demon!

On the other hand, a number of others seem to be newly broken. The current list is: AutoCreateCategoryPages Bootstrap Campaigns CirrusSearch CommunityTwitter CoreEvents EImage Less OpenStreetMapSlippyMap PerPageLicense QuickResponse TimelineTable WikibaseDataModel WikibaseQueryEngine

If you have a fully checked-out version of mediawiki/extensions (git pull && git submodule update --init --recursive), this bash script should tell you the submodules that aren't at master:

for m in `sed -n 's/\[submodule "\(.*\)"\]/\1/p' .gitmodules | sort`; do (
    cd $m;
    A=`git log -1 --format="%h %ci %s"`;
    B=`git log -1 --format="%h %ci %s" origin/master`;
    [ "$A" = "$B" ] || echo $m
); done

Of course, that won't catch anything that hasn't had a commit since being broken, if such a state is possible. If you want to see info on the actual commits, BTW, you can change 'echo $m' in there to something like 'echo -e "$m\n $A\n $B"'.

The issue is on Gerrit side. The check-sync.sh of mediawiki/extensions.git let us detect such issue.

Follow up on bug 49846 mediawiki/extensions.git does not update some extensions

  • This bug has been marked as a duplicate of bug 49846 ***