Page MenuHomePhabricator

CSSJanus: border-radius is incorrectly interpreted as top-right-bottom-left
Closed, ResolvedPublic

Description

echo CSSJanus::transform( 'border-radius: 0px 0px 5px 5px' );

border-radius: 0px 5px 5px 0px

https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius says:

border-radius: top-left top-right bottom-right bottom-left

So bottom-left suddenly changes to top-right, which is incorrect. Noticed this in ULS.


Version: 1.17.x
Severity: normal

Details

Reference
bz49074

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz49074.

Related URL: https://gerrit.wikimedia.org/r/66381 (Gerrit Change I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c)

See also bug 45677 (which has a patch pending).

Neither Niklas' patch nor I97ee7431e1a5acb (from bug 45677) addresses the issue with border-radius.

border-radius is already being flipped but incorrectly. It need to be changed from:
top-left-bottom-right
to:
top-left top-right bottom-right bottom-left

Or, in Janus:

from: (x1-LEFT-x2-RIGHT)
to: (LEFT-RIGHT)-(LEFT-RIGHT)

https://gerrit.wikimedia.org/r/66381 (Gerrit Change I411ea2cda0fcfc0c3182189ed6dc2f25851cd04c) | change APPROVED and MERGED [by jenkins-bot]

I'll submit a core patch soon.

I22bc777b is the core patch, Iac9e78b8 is a revert of the workaround in ULS.

Change 67264 merged by jenkins-bot:
CSSJanus: Handle values of border-radius correctly

https://gerrit.wikimedia.org/r/67264

Change 67265 merged by jenkins-bot:
Revert "Workaround for border-radius due to bug 49074"

https://gerrit.wikimedia.org/r/67265