Page MenuHomePhabricator

UserMerge should be re-factored using FormSpecialPage
Closed, ResolvedPublic

Description

Purely a code enhancement, but it would be better to re-factor the UserMerge page into a FormSpecialPage. It helps to get rid of repeated code and can also make validation automatic.


Version: master
Severity: enhancement

Details

Reference
bz49519

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 1:45 AM
bzimport set Reference to bz49519.

(In reply to comment #0)

Purely a code enhancement, but it would be better to re-factor the UserMerge
page into a FormSpecialPage. It helps to get rid of repeated code and can
also
make validation automatic.

Good idea, but for later. I need to fix other issues in other extensions first, This is why I did not set "assigned".

Yep, I figured. Just wanted to catalog it as a long-term goal.

Legoktm: this code-beautifying is a long-term goal. It is not as urgent as the other E:UserMergge issues you mentioned recently (Yes, I follow them, thanks, and will review soon. ETA ~2 weeks).

Change 139076 had a related patch set uploaded by Legoktm:
Use FormSpecialPage

https://gerrit.wikimedia.org/r/139076

Change 139076 merged by jenkins-bot:
Use FormSpecialPage

https://gerrit.wikimedia.org/r/139076