Strip linebreaks in uploaded ssh keys
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jun 13 2013, 10:35 PM

Description

Author: rlane32

Description:
Users often upload keys with line breaks. Public ssh keys shouldn't have line breaks and it should be safe to just always strip them when they are being uploaded.

Details

Reference: bz49553

	Subject	Repo	Branch	Lines +/-
	Trim SSH key input before processing	mediawiki/extensions/OpenStackManager	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rMEXT0921b44f42aa: Updated mediawiki/extensions Project: mediawiki/extensions/OpenStackManager…
rEOST86e2ec4b5cad: Trim SSH key input before processing
Mentioned Here: T97235: SSH key import should accept stray whitespace before / after key

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:48 AM

• bzimport added a project: wikitech.wikimedia.org.

• bzimport set Reference to bz49553.

• bzimport created this task.Jun 13 2013, 10:35 PM

Krenair merged a task: T97235: SSH key import should accept stray whitespace before / after key.Apr 25 2015, 10:21 PM

Krenair added subscribers: gerritbot, Andrew, Aklapper, yuvipanda.

Change 206610 had a related patch set uploaded (by Alex Monk):
Trim SSH key input before processing

https://gerrit.wikimedia.org/r/206610

gerritbot added a project: Patch-For-Review.Apr 25 2015, 10:21 PM

Krenair updated the task description. (Show Details)Apr 25 2015, 10:22 PM

Krenair edited projects, added MediaWiki-extensions-OpenStackManager; removed wikitech.wikimedia.org.

Krenair set Security to None.

Note that this is broader than T97235 - that only does a trim :)

Aklapper removed RyanLane as the assignee of this task.Apr 26 2015, 12:11 PM

Change 206610 merged by jenkins-bot:
Trim SSH key input before processing

https://gerrit.wikimedia.org/r/206610

Krenair mentioned this in rEOST86e2ec4b5cad: Trim SSH key input before processing.Apr 28 2015, 8:21 PM

Diffusion mentioned this in rMEXT0921b44f42aa: Updated mediawiki/extensions Project: mediawiki/extensions/OpenStackManager….Apr 28 2015, 8:21 PM

yuvipanda unsubscribed.Jun 30 2016, 2:02 PM

Meno25 unsubscribed.Jan 17 2017, 3:38 PM

Reedy closed this task as Resolved.Nov 10 2019, 3:48 AM

Reedy assigned this task to Krenair.

Reedy removed a project: Patch-For-Review.

Yuvi fixed it, I just added the task to the commit message and approved it :)

Strip linebreaks in uploaded ssh keysClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Strip linebreaks in uploaded ssh keys
Closed, ResolvedPublic
Actions