Page MenuHomePhabricator

VisualEditor: Closing (as opposed to applying) a dialog with no changes undoes last item in the stack anyway
Closed, ResolvedPublic

Description

https://en.wikipedia.org/wiki/Digital_Forensics_XML?veaction=edit

I went there, I changed a header from h3 to h2 by selecting the header and using the drop-down menu. When I click "Page settings" and then close the dialog box without making any changes, my change to the header is inexplicably lost.


Version: unspecified
Severity: normal

Details

Reference
bz49630

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:53 AM
bzimport set Reference to bz49630.

This looks like the code to "undo changes made in the dialog when they don't apply them" is doing that once too often.

Not quite, it's just doing it without checking if a new breakpoint was actually added.

Related URL: https://gerrit.wikimedia.org/r/69316 (Gerrit Change Ieb2e9e361afe057af93c4d374acc85df58bfb4c3)

Merged and will go out with wmf8.