Page MenuHomePhabricator

Broken custom signatures should return "Invalid raw signature. Check HTML tags." error and use default.
Closed, DuplicatePublic

Description

I'm creating this bug per https://en.wikipedia.org/wiki/Help_talk:Notifications/Archive_4#Why_wasn't_I_notified... where-as it seems that custom signatures that are missing closing tags are causing chaos. I'm thinking the best thing to do is to run a parsed version of the signature through http://validator.w3.org and refused with a little red error message on the preferences page saying "Invalid raw signature. Check HTML tags." and then use the default signature instead.


Version: unspecified
Severity: minor

Details

Reference
bz49695

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:58 AM
bzimport set Reference to bz49695.
bzimport added a subscriber: Unknown Object (MLST).
Technical13 raised the priority of this task from Low to Medium.Dec 25 2014, 9:59 PM

It wouldn't hurt if this validated as HTML5 as well.

There is a very similar proposal at T140606 that received a bit more attention, so I'll merge this one.