Page MenuHomePhabricator

Parsoid: DSR on DOM of some reused images is buggy (causing image fragments to be duplicated on save on some pages)
Closed, ResolvedPublic


See - without changing or going near the link, it ended up hamfistedly duplicated on save.

Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:00 AM
bzimport added a project: Parsoid-DOM.
bzimport set Reference to bz49729.

Most recently seen at - still there after the latest deploy, and going to be highly disruptive to popular (read: also probably very long, and image-filled) articles.

Appeared again at - this was an attempt to resize an image. Possibly the source? Investigating further.

Same cause as, but this time on images.

Ex: dsr":[20586,20590] on the sole image in

Fix coming -- to be tested, reviewed, and merged later today. All parsoid varnishes should be purged again.

This should be the last instance of bugs from reusing cached DOM fragments. 49655 fixed this for templates and extensions. This should fix it for images.

Related URL: (Gerrit Change Id6d7de70cecf6d5d9e79e2f9875a271487916dbe) (Gerrit Change Id6d7de70cecf6d5d9e79e2f9875a271487916dbe) | change APPROVED and MERGED [by jenkins-bot]

Seems partially fixed -- the egregious duplication issues seem to be gone.

But, I am seeing a different issue on after I made a minor edit.

Reviewing diffs on subsequent edits reveals bad wikitext changes (off-by-1-char) on one image. Looking at the HTML for that figure shows off-by-1 TSR and DSR values on pieces of that image which messes up the serialiation from that HTML.

Related URL: (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331)

Related URL: (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331) (Gerrit Change I32c511d05d62dd31bb19fca21aff792ddc422331) | change APPROVED and MERGED [by jenkins-bot]

  • Bug 49824 has been marked as a duplicate of this bug. ***

All the fixes for this have been deployed and caches purged of stale HTML. Could you all test independently and verify that the problems have been fixed before we close this out?

My testing on a couple pages shows that this is fixed. Closing. Please reopen if necessary.

Ssastry, I am afraid this is back, see . The user just added a wikilink - which is how you can reproduce the problem, the code is already corrupted in the preview.

No, this is bug 53071. I'll add this as another example of that bug and we'll try to get that bug fixed this week.