Page MenuHomePhabricator

On minor edit, no email notification for talk page (enotifusertalkpages)
Open, HighPublic

Description

In the last few days I'm noticing some email notifications getting lost. In particular, I didn't receive any for these three edits https://commons.wikimedia.org/?diff=98423184&oldid=97502053 and for https://commons.wikimedia.org/?diff=98428697&oldid=98428551, while I did for https://commons.wikimedia.org/?diff=prev&oldid=98428551.


Steps to reproduce, assuming all relevant wiki configs are set properly (e.g. on Commons right now):

  1. Ensure Echo is not installed on the wiki
  2. On [[Special:Preferences]], check that email is confirmed and "Email me when my user talk page is changed" (enotifusertalkpages) enabled
  3. Visit your talk page [shouldn't be needed, but who knows]
  4. Logout, login with an alternate account (but not one flagged as bot, see T40874)
  5. Edit the page marking the edit as minor

Observed: no email notification is sent.
Expected: an email notification is sent.


"E-mail me also for minor edits of pages" is not a possible reason because

  1. it never applied to talk page notifications, see [[mw:Manual:$wgEnotifMinorEdits]];
  2. it's not even available on Special:Preferences, although it used to and I've no idea when it disappeared. https://www.mediawiki.org/w/index.php?title=User_talk:Helder.wiki&diff=prev&oldid=712986

Version: 1.22.0
Severity: major

Details

Reference
bz49749

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:02 AM
bzimport added a project: MediaWiki-Email.
bzimport set Reference to bz49749.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Jun 18 2013, 3:01 PM

bsitu wrote:

There would be no talk page notification for minor edit if $wgEnotifMinorEdits is set to false

Thanks for the answer.

(In reply to comment #1)

There would be no talk page notification for minor edit if
$wgEnotifMinorEdits
is set to false

Why? That's not expected behaviour, docs say «This does not affect the user's own talk page (they will be notified about all changes, regardless of this setting)». https://www.mediawiki.org/w/index.php?title=Manual:$wgEnotifMinorEdits&diff=64049&oldid=64047
When did this change?

bsitu wrote:

The doc may be just referring to Orange Bar notice?

"Set to true to allow e-mail notification to be sent also for small (minor) edits. This does not affect the user's own talk page (they will be notified about all changes, regardless of this setting)."

(In reply to comment #3)

The doc may be just referring to Orange Bar notice?
"Set to true to allow e-mail notification to be sent also for small (minor)
edits. This does not affect the user's own talk page (they will be notified
about all changes, regardless of this setting)."

I doubt it, HappyDog would not be so imprecise.

(In reply to comment #4)

(In reply to comment #3)

The doc may be just referring to Orange Bar notice?
"Set to true to allow e-mail notification to be sent also for small (minor)
edits. This does not affect the user's own talk page (they will be notified
about all changes, regardless of this setting)."

I doubt it, HappyDog would not be so imprecise.

I would hope not, anyway. :-)

It was a long time ago now, so I don't fully remember, but at that time I was going through all the settings quite carefully, checking the actual code if necessary, therefore I would be surprised if that description was inaccurate.

That said, it was a long time ago, and whilst I would expect it to be valid at the point of writing, the software may have changed since then, so probably worth re-checking the code.

Cc Platonides because he just mistakenly sent several thousands talkpage notifications as minor edits on Commons for WLM, making all those users miss an enotif.

The traditional behavior (and what I expected) was that the edits would have to be minor and bot for not triggering the uer talk email.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2015, 11:07 PM

$wgEnotifMinorEdits *does* affect user talk (as well as watchlist), and is false on almost all WMF wikis, meaning users will never receive email notifications for minor edits on those wikis. There is also no preference override if the global is set to false.

I think a more logical approach for WMF would be to always set $wgEnotifMinorEdits to true, and set $wgDefaultUserOptions['enotifminoredits'] true or false depending on the wiki's preference.

Then individual users would always at least have the option to set it either way.

scfc awarded a token.Feb 26 2017, 6:22 PM
scfc added a subscriber: scfc.
Koavf added a subscriber: Koavf.Feb 26 2017, 7:44 PM
Dinoguy1000 updated the task description. (Show Details)Jul 25 2018, 2:05 PM