Page MenuHomePhabricator

Parsoid: External links are double encoded
Closed, ResolvedPublic

Details

Reference
bz50042

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:54 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz50042.
Krinkle created this task.Jun 23 2013, 9:27 AM

Looks like a Parsoid bug. Works fine when data-parsoid is present, but for new annotations URLs are encoded.

<a rel="mw:ExtLink" href="https://github.com/search?l=&amp;q=ResourceLoader+%40wikimedia">Search</a>

serialises to:

[https://github.com/search?l=&q=ResourceLoader+%2540wikimedia Search]

Change 71082 had a related patch set uploaded by GWicke:
Bug 50042: Don't percent-encode modified external link hrefs

https://gerrit.wikimedia.org/r/71082

Change 71082 merged by jenkins-bot:
Bug 50042: Don't percent-encode modified external link hrefs

https://gerrit.wikimedia.org/r/71082

We might later want to prettify the percent encoding. Basically decode everything but some vital percent-encoded values ([%? ], probably more). But for now this is fixed.