Page MenuHomePhabricator

VisualEditor: IME shift+ function for adding diacritical marks in Arabic broken
Closed, ResolvedPublic8 Estimated Story Points



"Hi. I have been using the visual editor for a while on ar Wikipedia, it is very nice and smooth for fast edits. However, I am facing a very strange problem when I need to add some Arabic diacritics known as tashkil; when I press shift+diacritic button (like x, e, or z) the letter I pressed starts to repeat itself endlessly, and it can only be stopped by refreshing the page and wasting the work I have did. Any thoughts?"

Version: unspecified
Severity: major
See Also:



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:58 AM
bzimport set Reference to bz50105.

Bumping priority, moving module, assigning, slight rewording; note that we can't fix things in the past (;-)), so setting to next week's deployment deadline.

Thanks James - first bug report.

(In reply to comment #2)

Thanks James - first bug report.

No worries. :-) Welcome to the party.

I think this may be resolved by the following patch: . It fixes similar bugs in other scripts with similar properties.

If it's still broken, is it possible to give a specific example of:

  1. A piece of Arabic text where VisualEditor fails
  2. The keystrokes required to enter the text
  3. The incorrect output observed in VisualEditor
  4. The OS, browser and input method used.


Change 80080 had a related patch set uploaded by Jforrester:
WIP:Don't emit Surface changes back to the Surface

aaddira wrote:

Thank you. I have tested all possible diacritics on Arabic Wikipedia and everything is working great. Good job!

Change 80080 merged by jenkins-bot:
Don't emit Surface changes back to the Surface

Given that this is now merged, I'm going to mark this as fixed. However, this is provisional - please re-open if you think that this has not worked!