Page MenuHomePhabricator

VisualEditor: First character after a </pre> is lost on round-trip
Closed, ResolvedPublic

Description

I edited a large page on meta (1.22wmf7) in VE. All seemed fine but review showed VE had removed the first character following several closing </pre> tags. It also removed a few characters within a <source> tag.

Here's the diff showing the removal, it's self-explanatory. https://www.mediawiki.org/w/index.php?title=Extension%3AEventLogging%2FGuide&diff=716359&oldid=704840. I will restore the characters by hand.
I'm using Firefox 21.0 on Kubuntu 13.04.

I tried editing the same document again and this time VE removed more characters from the source tag, added a space after a <pre>. Hmm. I'm setting to critical as it's recoverable data loss, but maybe it's intermittent.


Version: unspecified
Severity: critical

Details

Reference
bz50118

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:59 AM
bzimport set Reference to bz50118.

Making this primarily about the first character after a </pre> getting lost on round-trip; I'm not sure how you were able to edit inside a <source> tag, though, so that needs exploring too if it recurs.

Can't reproduce in master.

An issue I am seeing is code inside <source> and <syntaxhighligh> blocks are losing their linebreaks. Might want to file a bug if we aren't aware of that.

Editing inside source is now bug 50224

(In reply to comment #2)

Can't reproduce in master.

Neither can I, in production or master. I'm going to close this as fixed, but please re-open if it recurs.