Page MenuHomePhabricator

VisualEditor: Indentation toolbar buttons should not be enabled by default
Closed, ResolvedPublic

Description

They're currently enabled on page load. Even when dismissing the notice and clicking around in the first paragraph it stays.

It finally disables itself after a node change (e.g. click the second paragraph and then back).


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44083

Details

Reference
bz50141

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:01 AM
bzimport set Reference to bz50141.
Krinkle created this task.Jun 24 2013, 11:18 PM

From conversation earlier today:

It may be possible to hack the button to be disabled by default, but that would introduce the opposite bug where the indention tool would be disabled instead of enabled in a document that starts with a list, requiring the user to move out of the list and back in to be able to indent.

Basically we should make sure that our hooks that make the button enabled/disabled on node focus change also trigger when initially focussing the first node in the document (instead of only from the second node focus onwards).

Change 70936 had a related patch set uploaded by Robmoen:
Init surface after toolbar is setup vs. before.

https://gerrit.wikimedia.org/r/70936

Change 70936 merged by jenkins-bot:
Init surface after toolbar is setup vs. before.

https://gerrit.wikimedia.org/r/70936

This has been fixed and will be deployed very soon.