VisualEditor: Make ve.ui.PopupWidget#display signature not insane
Closed, ResolvedPublic

Description

3 parameters is the limit, 6 is crazy.

ve.ui.PopupWidget.prototype.display = function ( x, y, width, height, transition, embedded ) {


Version: unspecified
Severity: enhancement

bzimport added a project: Technical-Debt.Via ConduitNov 22 2014, 2:05 AM
bzimport set Reference to bz50197.
Krinkle created this task.Via LegacyJun 25 2013, 8:28 PM
Krinkle added a comment.Via ConduitOct 2 2014, 12:22 AM

Looking pretty good. It's been separated and the method itself (OO.ui.PopupWidget#display) no longer exists.

https://github.com/wikimedia/oojs-ui/blob/e43584b420/src/widgets/PopupWidget.js

Add Comment