Page MenuHomePhabricator

wikibits: Wrap mwCustomEditButtons in mw.log.deprecate
Closed, ResolvedPublic

Description

After reading bug 47872 comment 10 and looking for usage of mw.log.deprecate at
https://github.com/wikimedia/mediawiki-core/search?q=deprecate%28&type=Code
I believe the deprecation of "mwCustomEditButtons" is still to be done.

Creating this bug for that.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47872

Details

Reference
bz50310

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz50310.
He7d3r created this task.Jun 27 2013, 6:27 PM

It has been deprecated for sure (it is overwhelmed in almost 3 layers of legacy and deprecation since at least MediaWiki 1.17), but mw.log.deprecate is a feature that has only existed for a short while.

This one should indeed be wrapped with a warning as well to make the deprecation easier to detect.

+1 :)

If we use mw.log.deprecate on this then the warning will come up on every action=edit&debug=true page (even when no extension/user code is trying to use it) because of legacy support for it in mediawiki.action.edit.js. I don't know of any way to prevent that though...

Change 71176 had a related patch set uploaded by Alex Monk:
Deprecate mwCustomEditButtons

https://gerrit.wikimedia.org/r/71176

Per bug 47872 this currently doesn't work anyway, so the code in mediawiki.action.edit.js could be killed off, no?

Change 71176 merged by jenkins-bot:
Make mwCustomEditButtons a no-op and mark it as deprecated

https://gerrit.wikimedia.org/r/71176