Page MenuHomePhabricator

VisualEditor: Ctrl-Click / middle-click on a link should open it in another window; on an image, should open the image's description page
Closed, DeclinedPublic

Description

Using ctrl-click (but not middle-click) on a "content editable" link, does not currently work with Chromium37, but does work with Firefox39.
Using Middle-mouse-click on links does not work in either browser
Using Right-mouse-click to show the context menu with "Open link in new tab/window" does work in both browsers.

(Prior description had different results for Firefox 22.
Ed notes below, that this is all browser-specific behaviour, and rather than overriding that, we should just solve T56759: VisualEditor: Provide a way (beyond Ctrl-Click, middle-click, or right-click/tab) to open links in another window (Done))

See also: T52741: VisualEditor: Show a different cursor when Ctrl (Cmd on Mac) is held down, as the interaction will be different

Details

Reference
bz50321

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:43 AM
bzimport set Reference to bz50321.

Some more details:

  • Middle mouse click on internal text links: OK (but mouse cursor wrong)
  • Middle mouse click on images: NOT OK
  • Middle mouse click on external links: NOT OK

The mouse cursor not changing is bug 50741

CTRL+click / right click and open in a new window/tab does work for internal and external links. It does not work for images.

  • Bug 64974 has been marked as a duplicate of this bug. ***

Middle click/ctrl click on *content editable* links in browser specific behaviour, and isn't necessarily going to be the same as for read-only links. Rather than override the browser's default behaviour we will provide a consistent way to follow links with bug 54759.

Image nodes are protected from editing with highlights so we're not going to able to provide the normal context menu. I can't see a compelling use case, but such functionality may be available in the image dialog in the future.

Suggest wontfix for this.

Note/update: Using ctrl-click (but not middle-click) on a "content editable" link, does not currently work with Chromium37, but does work with Firefox39.
I will update the description to clarify.

Quiddity set Security to None.
Jdforrester-WMF claimed this task.

The main request here was satisfied in T56759: VisualEditor: Provide a way (beyond Ctrl-Click, middle-click, or right-click/tab) to open links in another window and for non-links more generally in the context menu stuff done in March-ish. I agree with Ed that breaking people's browsers' behaviour isn't desireable.