Page MenuHomePhabricator

VisualEditor: ref warning appears within template that contains references, post-modification
Closed, ResolvedPublic



See the screenshot; I imagine the reference is being treated as existing within the template, rather than within the template within the page - it hunts for <references\>, can't find a tag in the template itself, and freaks the heck out.

Version: unspecified
Severity: minor
See Also:


refref.png (708×1 px, 109 KB)



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:50 AM
bzimport set Reference to bz50423.

The short-term fix is to just strip this comment from the returned HTML that the PHP parser gives us.

When we switch over to using Parsoid for this, we'll need that to run in context, somehow, so the references are correctly numbered and that we know to update the relevant reference lists.

Change 73092 had a related patch set uploaded by Esanders:
Hide ref errors inside MW transclusions

Change 73092 merged by jenkins-bot:
Hide ref errors inside MW transclusions

These are now hidden by the above commit, which we're deploying in the next few minutes.

Should probably leave this open to track improvements.

Change 73614 had a related patch set uploaded by Esanders:
Use new class to detect Cite errors inside templates

I'm forking this off into bug 51337.