VisualEditor: ref warning appears within template that contains references, post-modification
Closed, ResolvedPublic

Description

Screenshot

See the screenshot; I imagine the reference is being treated as existing within the template, rather than within the template within the page - it hunts for <references\>, can't find a tag in the template itself, and freaks the heck out.


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51337

Attached:

bzimport set Reference to bz50423.
Ironholds created this task.Via LegacyJun 29 2013, 2:22 PM
Jdforrester-WMF added a comment.Via ConduitJul 1 2013, 2:56 PM

The short-term fix is to just strip this comment from the returned HTML that the PHP parser gives us.

When we switch over to using Parsoid for this, we'll need that to run in context, somehow, so the references are correctly numbered and that we know to update the relevant reference lists.

gerritbot added a comment.Via ConduitJul 10 2013, 9:36 PM

Change 73092 had a related patch set uploaded by Esanders:
Hide ref errors inside MW transclusions

https://gerrit.wikimedia.org/r/73092

gerritbot added a comment.Via ConduitJul 10 2013, 11:05 PM

Change 73092 merged by jenkins-bot:
Hide ref errors inside MW transclusions

https://gerrit.wikimedia.org/r/73092

Jdforrester-WMF added a comment.Via ConduitJul 10 2013, 11:13 PM

These are now hidden by the above commit, which we're deploying in the next few minutes.

Esanders added a comment.Via ConduitJul 11 2013, 11:44 AM

Should probably leave this open to track improvements.

gerritbot added a comment.Via ConduitJul 14 2013, 2:41 PM

Change 73614 had a related patch set uploaded by Esanders:
Use new class to detect Cite errors inside templates

https://gerrit.wikimedia.org/r/73614

Jdforrester-WMF added a comment.Via ConduitJul 15 2013, 1:46 AM

I'm forking this off into bug 51337.

Add Comment