Page MenuHomePhabricator

Canceling font change doesn't work for system font
Closed, ResolvedPublic

Description

  1. Go to http://en.wikipedia.org/wiki/Main_Page
  2. Click Cog
  3. Click [Fonts]
  4. Choose Open Dyslexic for English
  5. Click [Apply]
  6. Click Cog
  7. Choose system for English
  8. Click [Cancel]

Observed: System is stays as the chosen font
Observed: Open Dyslexic is back when page is refreshed
Expected: Reverted back to Open Dyslexic immediately when clicking cancel


Version: master
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57655

Details

Reference
bz50562

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:00 AM
bzimport set Reference to bz50562.
  • Bug 50563 has been marked as a duplicate of this bug. ***

This happens only when system(pageload)->fontA(apply)->system(cancel) UX sequence.

Works as expected in fontA(pageload)->system(cancel) cases.

Reason for bug:

The "previous font" value is set on page load and does not get updated on next font changes. So cancel is pressed, this "previous font" is applied.

Change 74583 had a related patch set uploaded by Santhosh:
Update the previous UI and content font whenever font value changes

https://gerrit.wikimedia.org/r/74583

Change 74583 merged by jenkins-bot:
Update the previous UI and content font whenever font value changes

https://gerrit.wikimedia.org/r/74583

  • Bug 52571 has been marked as a duplicate of this bug. ***